eds/lrs: handle nil when LRS is disabled#4086
Merged
menghanl merged 3 commits intogrpc:masterfrom Dec 7, 2020
Merged
Conversation
menghanl
force-pushed
the
xds_lrs_disabled
branch
from
d0a343a to
48bc9f3
Compare
dfawley
approved these changes
Dec 7, 2020
| edsb := newEDSBalancerImpl(cc, nil, lsWrapper, nil) | ||
| edsb.enqueueChildBalancerStateUpdate = edsb.updateState | ||
|
|
||
| // Two localities, each with one backend. |
| clab1 := testutils.NewClusterLoadAssignmentBuilder(testClusterNames[0], nil) | ||
| clab1.AddLocality(testSubZones[0], 1, 0, testEndpointAddrs[:1], nil) | ||
| edsb.handleEDSResponse(parseEDSRespProtoForTesting(clab1.Build())) | ||
| sc1 := <-cc.NewSubConnCh |
Comment on lines
+750
to
+752
| // We create an xdsClientWrapper with a dummy xdsClientInterface which only | ||
| // implements the LoadStore() method to return the underlying load.Store to | ||
| // be used. |
Member
There was a problem hiding this comment.
This doesn't make 100% sense anymore I think.
menghanl
added a commit
that referenced
this pull request
Jan 11, 2021
menghanl
added a commit
that referenced
this pull request
Jan 11, 2021
This was referenced Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking
nilbefore calling the methods. Even though the implementation's receiver checks for nil, the interfacenildoesn't have the implementation type, and won't call the implementation's receiver.https://play.golang.org/p/LilYpHAr84j